Project 1999
Page 2 of 3 1 2 3
Show 10 post(s) from this thread on one page

Project 1999 (/forums/index.php)
-   Resolved Issues (/forums/forumdisplay.php?f=14)
-   -   Spells: damage shields doing reduced damage in pvp (/forums/showthread.php?t=51359)

Lasher 10-19-2011 01:50 PM
I dont recall ds doing reduced dmg in pvp, it did on vztz. Unless there is proof showing live had ds pvp dmg reduced i think it would be ridiculous considering ds last aroud 5 mins so to add reduction to it would severly gimp the applications of it in pvp

Nirgon 10-21-2011 07:51 PM
It did full damage in pvp.

There will be much crying and disputing, but it was full.

Alecta 04-21-2013 10:50 PM
In spdat.h:

Code:
bool IsDamageShieldSpell(uint16 spell_id);
In spdat.cpp:

Code:
///////////////////////////////////////////////////////////////////////////////
// spell property testing functions

bool IsDamageShieldSpell(uint16 spell_id)
{
        return IsEffectInSpell(spell_id, SE_DamageShield);
}
In attack.cpp (adapt as is necessary, as I am sure its customized):
Code:
        // cut all PVP spell damage to 2/3 -solar
        // EverHood - Blasting ourselfs is considered PvP
        //Don't do PvP mitigation if the caster is damaging himself
        if(other && other->IsClient() && (other != this) && damage > 0 && !IsDamageShieldSpell(spell_id) ) {

Smedy 04-22-2013 08:30 AM
Yep remember full, can't prove, cause i'm way to lazy to google, but someone can probably dig it up

heartbrand 04-22-2013 10:30 AM
Null is on it

Bamzal Sherbet 04-22-2013 11:01 AM
confirmed DS's were a more serious issue on live

Nirgon 04-22-2013 12:35 PM
Quote:
Originally Posted by heartbrand (Post 929846)
Null is on it
Null's gone. Time to own the issue.

Alecta 04-22-2013 12:44 PM
Yeah, which is why I provided an implementation, which we're burying with each subsequent post.

Ruprecht 04-23-2013 09:34 AM
Quote:
Originally Posted by Alecta (Post 930032)
Yeah, which is why I provided an implementation, which we're burying with each subsequent post.
Yeah, the devs haven't fixed it yet because all this time they were desperately awaiting that prophesied day when a random member of the community should arrive to bestow upon them a few lines of trivial code.

:rolleyes:

Alecta 04-23-2013 10:40 AM
Eh, was just going off http://www.project1999.org/forums/showthread.php?t=6897, which is why I bumped the year and a half old post with all the 'proof' with a code submission.

But if the preferred approach is to just QQ and snipe, I can roll with that too.


All times are GMT -4. The time now is 03:12 PM.
Page 2 of 3 1 2 3
Show 10 post(s) from this thread on one page

Powered by vBulletin®
Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.