Request for Review of P99 Source

[Cyph]

Originally Posted by Byrjun [You must be logged in to view images. Log in or Register.]

Agree, I also used to get a ping around 36, sometimes even in the 20s. Since the last patch it probably averages about 120-140, sometimes even higher.

Being Australian, I get excited if my ping dips to 299ms...

[tristantio]

I'm pretty sure (at least the current server source code for eqemu) is GPL, which means if any of that is reused on p99 the p99 codebase is GPL and source has to be given to anyone who requests it (as long as they've been distributed the end product - not really the case here though).

Since we're just connecting to the server and not playing a distributed game, this would not be affected by GPL (unless the project were AGPL - Affero GPL, in which case simply providing a server requires release of source code to whomever asks and uses said server).

However, I wonder if any part of the custom DLL's/distributed files that p99 provides incorporate GPL'ed code (whether GPL'ed via the eqemu server source release, or by including GPL'ed code from other GPL projects).

Edit: I'm a big fan of the AGPL myself (and use in my own projects) so if someone ends up using something I spend my time on, they can't simply close off the source by using the "service" loophole of the original GPL.

[a_gnoll_pup]

Originally Posted by tristantio [You must be logged in to view images. Log in or Register.]

I'm pretty sure (at least the current server source code for eqemu) is GPL, which means if any of that is reused on p99 the p99 codebase is GPL and source has to be given to anyone who requests it (as long as they've been distributed the end product - not really the case here though).

Since we're just connecting to the server and not playing a distributed game, this would not be affected by GPL (unless the project were AGPL - Affero GPL, in which case simply providing a server requires release of source code to whomever asks and uses said server).

However, I wonder if any part of the custom DLL's/distributed files that p99 provides incorporate GPL'ed code (whether GPL'ed via the eqemu server source release, or by including GPL'ed code from other GPL projects).

Edit: I'm a big fan of the AGPL myself (and use in my own projects) so if someone ends up using something I spend my time on, they can't simply close off the source by using the "service" loophole of the original GPL.

If everyone followed GPL like you are saying, every major MMO would have to distribute their code to the public because they use zlib or components of GNU.

I'm pretty sure no one at EQEmulator cares that P99 is doing what they are doing either, mainly because P99 is one of our contributors - and we're provided hosting by Rogean for PEQ, Loginserver, etc.

The DLL itself does not use EQEmulator or MQ2 code - it uses raw assembly and C++. The version that some of you have seen is an early test version made by myself that was never distributed by Project 1999. I have made both wsock32.dll and dsetup.dll versions of my test DLL that does not interact with the Project 1999 server in any way (it can't even connect), neither of which contain any code that Project 1999 or its affiliates use.

[loramin]

Originally Posted by tristantio [You must be logged in to view images. Log in or Register.]

However, I wonder if any part of the custom DLL's/distributed files that p99 provides incorporate GPL'ed code (whether GPL'ed via the eqemu server source release, or by including GPL'ed code from other GPL projects).

I think for the GPL to work like that the code has to be distributed, and in the case of server code it never gets distributed. This is one of the "loopholes" (if you're a Stallman fan) that GPL3 "fixes".

[quido]

It is more than just the recent ghosting issue. Even before the TT fixes there existed a lot of issues. I'm talking about issues like this, and the issue of mobs appearing to be pathing at 2 o'clock, then teleporting 10 feet in the 9 o'clock direction from where they started, and pathing at 2 o'clock again, over and over. We have been dealing with these issues for over a year. Even though we deal with these bugs every day, nobody seems interested in fixing them. Why not let people help? I don't think you guys really have that much in the source that is that precious, and what is there you could simply not share. I think most of the source fixes on P99 are pretty obvious and you are simply doing yourselves a disservice by not throwing some of these problems at the community.

There's a lot of smart people out here.

[tristantio]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

I think for the GPL to work like that the code has to be distributed, and in the case of server code it never gets distributed. This is one of the "loopholes" (if you're a Stallman fan) that GPL3 "fixes".

Yea, that is what my post went on to mention (although I reference AGPL since it covers a bit more, AGPL3 that is) [You must be logged in to view images. Log in or Register.]

If anyone wants some code to read/work on/contribute to, I have lots of open source projects on my github [You must be logged in to view images. Log in or Register.]

[baalzy]

Any chance this is related to the higher populations? Or is it still this bad during off-peak hours? I've been lazily doing a static camp for the past week so haven't seen much problem with ghosting.

I have noticed when feign splitting a camp that the mobs don't smoothly return to the camp, instead they kinda warp back to it a few feet at a time while facing the wrong direction.

[redbug2]

Originally Posted by baalzy [You must be logged in to view images. Log in or Register.]

Any chance this is related to the higher populations? Or is it still this bad during off-peak hours? I've been lazily doing a static camp for the past week so haven't seen much problem with ghosting.

I have noticed when feign splitting a camp that the mobs don't smoothly return to the camp, instead they kinda warp back to it a few feet at a time while facing the wrong direction.

No chance at all. I play off peak and try to attack shit that isn't there all the time. Fuck you early access velious pledgers.

[Sirken]

its fixed, just needs patch

[quido]

Originally Posted by Sirken [You must be logged in to view images. Log in or Register.]

its fixed, just needs patch

I hope they've fixed more than just what was broken with the last patch.

if mobs started pathing correctly and stopped teleporting/ghosting, I will be ecstatic