Moss covered Twig

[bcbrown]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

The Main Hand timer and the Off Hand timer are independent, but the only way an Off Hand Swing can be triggered is via a Main Hand Swing.

This is definitely wrong, but it does explain some of the more baffling computational errors DSM has made in the past.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

This is definitely wrong, but it does explain some of the more baffling computational errors DSM has made in the past.

I understand you simply want to discredit me in anyway possible. You aren't objective when it comes to these discussions, and your quick gloating posts like this provide more evidence for your lack of objectivity. Your errors with my calculator were due to misuse. You didn't read how to use it, and then complained your DPS was too low when you gave a level 45 mob the same amount of AC as a raid mob.

It is only a minor error in the calculator if this turns out to be true. It wouldn't have affected the actual DPS tests I've done in the past on P99 that were tested against the calculator to confirm it was working.

The P99 tests I have done have all been using two handed weapons, one handed weapons on classes that cannot dual wield, or offhand weapons with a delay greater than or equal to the main hand. The calculator in it's current form will produce the same dual wield results as a 100% independent offhand timer when using a offhand weapon with a delay greater than the main hand. It simply won't give you extra DPS when using a offhand weapon with less delay than the main hand.

[bcbrown]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

It simply won't give you extra DPS when using a offhand weapon with less delay than the main hand.

This is also wrong. Your DPS calculator treats low-delay offhand weapons correctly, as far as I can tell. Leaving all the values as default except making the mainhand 25/40 and the offhand 10/20 gives a DPS value of about 26. Making the offhand 10/30 gives a DPS of about 23. I'm using the wiki version. 10/40 offhand gives 21-22 DPS.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

This is also wrong. Your DPS calculator treats low-delay offhand weapons correctly, as far as I can tell. Leaving all the values as default except making the mainhand 25/40 and the offhand 10/20 gives a DPS value of about 26. Making the offhand 10/30 gives a DPS of about 23. I'm using the wiki version. 10/40 offhand gives 21-22 DPS.

1. The wiki version is way out of date. If you read the thread you would know this. Loramin hasn't updated it to version 2.0 yet. The initial version I posted wasn't finished. I've asked Loramin to update it or take it down, but he hasn't done either.

2.Can you please show me the line of code that handles the offhand timer in the latest version of the code that is on google drive? If you think you understand my calculator well enough, then please show it and explain it.

[bcbrown]

I'm saying the wiki version seems to correctly treat offhand delay. Did you really mess it up in the later version?

function computeWeaponDelayWithHaste(attackerStatStruct, bUseOffhand, bLogHasteValue)
{
	const mn_WeaponDelayDenominator = 100;

	var attackerWeaponDelay = attackerStatStruct.mainHandWeaponDelay;
	if(bUseOffhand)
	{
		attackerWeaponDelay = attackerStatStruct.offHandWeaponDelay;
	}
	...
}

function RunCombatSimulation(...)
{
	...
	const mainHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, false, false) / 10);
	const offHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, true, false) / 10);
	...
	const mainHandOffHandDelayRatio = (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) < 1 ? (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) : 1; 	// Off hand cannot be faster than mainhand. Clamp to 1 if off hand is faster.
}

Lmao I guess so.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

I'm saying the wiki version seems to correctly treat offhand delay. Did you really mess it up in the later version?

function computeWeaponDelayWithHaste(attackerStatStruct, bUseOffhand, bLogHasteValue)
{
	const mn_WeaponDelayDenominator = 100;

	var attackerWeaponDelay = attackerStatStruct.mainHandWeaponDelay;
	if(bUseOffhand)
	{
		attackerWeaponDelay = attackerStatStruct.offHandWeaponDelay;
	}
	...
}

function RunCombatSimulation(...)
{
	...
	const mainHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, false, false) / 10);
	const offHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, true, false) / 10);
	...
	const mainHandOffHandDelayRatio = (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) < 1 ? (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) : 1; 	// Off hand cannot be faster than mainhand. Clamp to 1 if off hand is faster.
}

Lmao I guess so.

You read the code wrong, and you are still referencing wiki results after I told you it wasn't finished. As I've said before, you need to actually read. I'd be curious to know if you can figure out what the issues were.

[bcbrown]

That's the new code, I didn't look at the old code. I just noticed that the DPS prediction (on the wiki) went down when you increased the offhand delay and figured it was correctly handling offhand delay.

Are you saying both versions incorrectly handle offhand delay? That's even funnier.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

That's the new code, I didn't look at the old code. I just noticed that the DPS prediction (on the wiki) went down when you increased the offhand delay and figured it was correctly handling offhand delay.

Are you saying both versions incorrectly handle offhand delay? That's even funnier.

You still haven't shown where the offhand is timer in either codebase. So you don't know how either work.

Keep the gloating posts coming, they just prove my point about you further.

[bcbrown]

I don't care about your DPS calculator, whether it's right or wrong. Just not useful for me. If you find it useful, great!

I'm just amused you wrote a whole-ass DPS simulator without knowing that offhand weapons aren't triggered off mainhand swings.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

I don't care about your DPS calculator, whether it's right or wrong. Just not useful for me. If you find it useful, great!

I'm just amused you wrote a whole-ass DPS simulator without knowing that offhand weapons aren't triggered off mainhand swings.

This is precisely why you are a poor contributor to this forum.

Instead of being interested in what other people have done/contributed, you mainly care about finding mistakes and attacking people for them. You focus more on that than actually trying to help people or understand the game.

At least you exposed yourself for people to see. Thanks for that.

Thank you to Zuranthium and Goregasmic for pointing out the independent offhand timer!

I'll fix the calculator and update it soon, it's only a few lines of code that need changing. This is why I shared my calculator, so I could get input from other players to see if I missed anything.