PDA

View Full Version : Merchants: wrong items from vendor


Morndenkainen
06-29-2010, 04:50 PM
I know this is going to sound like a joke, but I went to buy a sapphire off the vendor in the N freeport bank, and wound up with a fire emerald. You can see in the screenshot that I had the sapphire highlighted, its in the transaction box, you can see the vendor telling me what im buying and confirming the price, but when I hit the buy button to buy one, You can clearly see, that I paid the price for a fire emerald and that there's 2 lines of fire emeralds on the vendor's trade box.. Kinda hit me like a total WTF moment. Anyways, here's the screenshot cause I know nearly everyone would say im full of crap without it...

Dersk
06-29-2010, 05:06 PM
I had an instance where I bought something that I hadn't clicked. I paid the price for the one I had clicked on (but did not get), though.

However, when *that* happened, the mouse could no longer open containers, move items, start transactions with merchants, or open doors. Keyboard commands still worked. Logging fixed it.

I didn't check to see if the item I wanted to purchase changed like yours did, but I was also dealing with items that only had one quantity on the vendor.

Morndenkainen
06-29-2010, 05:15 PM
Thats just the thing though, I clicked on the "sapphire", clicked buy, selected quantiy of 1, hit enter, and wound up with a fire emerald... Had plenty of room in the bags, nothing else on the cursor, and no other weird issues going on. Just took me completley by suprise.

Reiker
06-29-2010, 05:35 PM
a) Player A opens vendor window, wants to buy Item01
b) Player B opens vendor window, buys Item01 (vendor's offered items don't update while Player A still has the window open)
c) Player A buys item Item01, but the vendor no longer has it for sale, so you end up getting item Item02 on its list.

Yinaltin
06-29-2010, 06:20 PM
had something similar . wanted to buy research words in freeport bank form the merchant . clicked and clicked and suddenly "your out of money" ... i bought some creepe iron stone bare stuff . each was like 200 pp ! sold back for 10 pp or less ! wasted about 1 k ! stupid p99 coders !:)

Xenephex
06-29-2010, 08:06 PM
a) Player A opens vendor window, wants to buy Item01
b) Player B opens vendor window, buys Item01 (vendor's offered items don't update while Player A still has the window open)
c) Player A buys item Item01, but the vendor no longer has it for sale, so you end up getting item Item02 on its list.
Actually, I'm pretty sure that player A has to buy the same item that Player B was wanting. I think if he (or she) buys or sells anything that changes the number of items the vendor has, then the other player that has the vendor window open can end up 'sliding' one slot in either direction without doing anything.

Would be easy to test if I had any friends.

mmiles8
06-29-2010, 10:05 PM
I'm pretty sure that player A has to buy the same item that Player B was wanting
Not the case, I had this happen to me with a pair of research words, once I realized what had happened, I went back and bought what I had intended to buy.

Haynar
06-29-2010, 10:56 PM
Is this new? Or has this been happening for awhile?

Haynar

Gorgetrapper
06-29-2010, 11:35 PM
This has been happening for a really long time.

Haynar
06-29-2010, 11:53 PM
This has been happening for a really long time.
Thank you. That helps considerably. I made some changes to merchants, but it should not have had anything to do with this issue. My changes screwed up the item charges. Remember those bugs? Ya, that was me. Oops.

I remember the code was a mess, and it looked like it did do some weird things. I will have to spend some time with it, and figure out what it is really doing.

Haynar

Thrynn
08-25-2010, 01:30 AM
After the rollback i noticed that the aviak vendor in SK gives you a different item than you purchased. Bought a small gem to reduce coin weight, and, recieved some kind of jewelry when i purchased, tried it again received a preserved splitpaw eye (in game name: thrynn)

Uthgaard
08-25-2010, 08:30 AM
This bug has been around for a while, but I dragged Spirell along to help me test it. This is with all vendors btw. Found the exact steps to reproduce this.

Multiple people go to one vendor. If one person buys or sells items to the vendor, causing the vendor to gain or lose a non-permanent item from stock, the table entries shift places.

Other players who had that window open will still purchase the correct items from the list, while all players still have their window open.

The moment the player that caused the vendor stock to shift closes the window, any players with their window still open will purchase incorrect items. Closing the window only executes that individual's changes.
I tested to see whether it would happen if someone else closed their window after I cleared out items, and it didn't.

So closing the window is the event that runs all of the queries on the actual table, maybe could give each spot in vendor stock an absolute reference in the table, since it's limited to a fixed amount of items in display, instead of allowing them to shift with each table update.