Upcoming changes

[GODPARTICLE]

	char phrase[255];
	database.GetRandPvPSaying(phrase);
	
	worldserver.SendEmoteMessage(0,0,0,15,
		"%s (%u %s) <%s> %s %s (%u %s) <%s>  in %s!",
			this->GetName(),this->GetLevel(),classes[this->GetClass()],guild_mgr.GetGuildName(this->GuildID()),
			phrase,
			killer->GetName(),killer->GetLevel(),classes[killer->GetClass()],guild_mgr.GetGuildName(killer->GuildID()),
			zone->GetLongName()
	);

[Rogean]

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

	char phrase[255];
	database.GetRandPvPSaying(phrase);
	
	worldserver.SendEmoteMessage(0,0,0,15,
		"%s (%u %s) <%s> %s %s (%u %s) <%s>  in %s!",
			this->GetName(),this->GetLevel(),classes[this->GetClass()],guild_mgr.GetGuildName(this->GuildID()),
			phrase,
			killer->GetName(),killer->GetLevel(),classes[killer->GetClass()],guild_mgr.GetGuildName(killer->GuildID()),
			zone->GetLongName()
	);

database.GetRandPvPSaying(phrase); ? You're pulling an SQL Query every time you want to get a phrase? I almost didn't read past this horrible bit of inefficiency.

"%s (%u %s) <%s> %s %s (%u %s) <%s> in %s!"

Lack of guild causes unnecessary ") <> ". This is why I have %s%s%s, If there's no guild name, why add the extra support text around it. It looks cleaner.
You have an extra space before "in".

I did forget the zone name, I'll add that to mine.

[Tomato King6]

desperate for attention

[GODPARTICLE]

btw what is that Rogean perl or something? What's the world coming to with ternary operations in a string format. Wonder if that's valid in C/C++

[GODPARTICLE]

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

btw what is that Rogean perl or something? What's the world coming to with ternary operations in a string format. Wonder if that's valid in C/C++

I thought it would be, my assumption is correct

#include <stdio.h>

int main()
{
    const int b = 1;
    printf("%s %s", b ? "cando" : "nutdo", !b ? "cando" : "nutdo");

    return 0;
}

output

cando nutdo

compiles with both c and c++

[GODPARTICLE]

its a myisam table. reads are virtually 0 overhead for how often a pvp slaying happens, especially compared to the trillions of database calls happening constantly. I did it so they could be added in realtime without recompiling and resetting the server, but it could be hardcoded array (mt_rand might have the same overhead realistically)

oh the original line with <> was a copypasta of null's code

[Rogean]

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

its a myisam table. reads are virtually 0 overhead

Are you forgetting all the overhead of actually running an SQL Query? The amount of code that then needs to be executed through the database functions, then the TCP code.. THEN we get to the actual mysql / myisam portion while the server process sits and twiddles it's thumbs (non asynchronous db call). Then repeat in reverse. I'll pass on that.

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

especially compared to the trillions of database calls happening constantly.

Not on my servers. There's a reason P99 holds more stability with hundreds of people online / in same zones compared to other servers. We moved away from on-demand sql queries a long time ago, preferring caches whenever possible.

[Smedy]

Originally Posted by Rogean [You must be logged in to view images. Log in or Register.]

Are you forgetting all the overhead of actually running an SQL Query? The amount of code that then needs to be executed through the database functions, then the TCP code.. THEN we get to the actual mysql / myisam portion while the server process sits and twiddles it's thumbs (non asynchronous db call). Then repeat in reverse. I'll pass on that.




Not on my servers. There's a reason P99 holds more stability with hundreds of people online / in same zones compared to other servers. We moved away from on-demand sql queries a long time ago, preferring caches whenever possible.

rogean just took a shit on this self proclaimed genius godparticle sons, put some ones and zeros into red99 so we can get some shit done now

[Inkanddagger]

Originally Posted by Smedy [You must be logged in to view images. Log in or Register.]

rogean just took a shit on this self proclaimed genius godparticle sons, put some ones and zeros into red99 so we can get some shit done now

[You must be logged in to view images. Log in or Register.]

[Feniggles]

plz send updates to my icq = 7050258