Upcoming changes

[Rogean]

"[PvP] %s%s%s%s has been defeated by %s%s%s%s!", GetName(), GuildID() ? " <" : "", GuildID() ? guild_mgr.GetGuildName(GuildID()) : "", GuildID() ? ">" : "", Killer->GetName(), Killer->CastToClient()->GuildID() ? " <" : "", Killer->CastToClient()->GuildID() ? guild_mgr.GetGuildName(Killer->CastToClient()->GuildID()) : "", Killer->CastToClient()->GuildID() ? ">" : ""

[GODPARTICLE]

	char phrase[255];
	database.GetRandPvPSaying(phrase);
	
	worldserver.SendEmoteMessage(0,0,0,15,
		"%s (%u %s) <%s> %s %s (%u %s) <%s>  in %s!",
			this->GetName(),this->GetLevel(),classes[this->GetClass()],guild_mgr.GetGuildName(this->GuildID()),
			phrase,
			killer->GetName(),killer->GetLevel(),classes[killer->GetClass()],guild_mgr.GetGuildName(killer->GuildID()),
			zone->GetLongName()
	);

[Feniggles]

Originally Posted by Rogean [You must be logged in to view images. Log in or Register.]

"[PvP] %s%s%s%s has been defeated by %s%s%s%s!", GetName(), GuildID() ? " <" : "", GuildID() ? guild_mgr.GetGuildName(GuildID()) : "", GuildID() ? ">" : "", Killer->GetName(), Killer->CastToClient()->GuildID() ? " <" : "", Killer->CastToClient()->GuildID() ? guild_mgr.GetGuildName(Killer->CastToClient()->GuildID()) : "", Killer->CastToClient()->GuildID() ? ">" : ""

so much for a troll free thread.

[GODPARTICLE]

btw what is that Rogean perl or something? What's the world coming to with ternary operations in a string format. Wonder if that's valid in C/C++

[Rogean]

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

	char phrase[255];
	database.GetRandPvPSaying(phrase);
	
	worldserver.SendEmoteMessage(0,0,0,15,
		"%s (%u %s) <%s> %s %s (%u %s) <%s>  in %s!",
			this->GetName(),this->GetLevel(),classes[this->GetClass()],guild_mgr.GetGuildName(this->GuildID()),
			phrase,
			killer->GetName(),killer->GetLevel(),classes[killer->GetClass()],guild_mgr.GetGuildName(killer->GuildID()),
			zone->GetLongName()
	);

database.GetRandPvPSaying(phrase); ? You're pulling an SQL Query every time you want to get a phrase? I almost didn't read past this horrible bit of inefficiency.

"%s (%u %s) <%s> %s %s (%u %s) <%s> in %s!"

Lack of guild causes unnecessary ") <> ". This is why I have %s%s%s, If there's no guild name, why add the extra support text around it. It looks cleaner.
You have an extra space before "in".

I did forget the zone name, I'll add that to mine.

[Smedy]

Originally Posted by Rogean [You must be logged in to view images. Log in or Register.]

"[PvP] %s%s%s%s has been defeated by %s%s%s%s!", GetName(), GuildID() ? " <" : "", GuildID() ? guild_mgr.GetGuildName(GuildID()) : "", GuildID() ? ">" : "", Killer->GetName(), Killer->CastToClient()->GuildID() ? " <" : "", Killer->CastToClient()->GuildID() ? guild_mgr.GetGuildName(Killer->CastToClient()->GuildID()) : "", Killer->CastToClient()->GuildID() ? ">" : ""

pras the lawd, he is pushing buttons in some sequence that may or may not be corrrect

welcome back rogean

[GODPARTICLE]

its a myisam table. reads are virtually 0 overhead for how often a pvp slaying happens, especially compared to the trillions of database calls happening constantly. I did it so they could be added in realtime without recompiling and resetting the server, but it could be hardcoded array (mt_rand might have the same overhead realistically)

oh the original line with <> was a copypasta of null's code

[Feniggles]

plz send updates to my icq = 7050258

[Rogean]

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

its a myisam table. reads are virtually 0 overhead

Are you forgetting all the overhead of actually running an SQL Query? The amount of code that then needs to be executed through the database functions, then the TCP code.. THEN we get to the actual mysql / myisam portion while the server process sits and twiddles it's thumbs (non asynchronous db call). Then repeat in reverse. I'll pass on that.

Originally Posted by GODPARTICLE [You must be logged in to view images. Log in or Register.]

especially compared to the trillions of database calls happening constantly.

Not on my servers. There's a reason P99 holds more stability with hundreds of people online / in same zones compared to other servers. We moved away from on-demand sql queries a long time ago, preferring caches whenever possible.

[Andis]

when will this be ready by?!?!!